Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgres_test: require no error, not assert no error #860

Merged
merged 1 commit into from
Jul 11, 2019
Merged

postgres_test: require no error, not assert no error #860

merged 1 commit into from
Jul 11, 2019

Conversation

srenatus
Copy link
Contributor

Trying not to inflate my WIP PR...

@srenatus
postgres_test: require no error, not assert no error
0ddced3 
Signed-off-by: Stephan Renatus <srenatus@chef.io>
@srenatus srenatus self-assigned this Jul 11, 2019
stevendanna
stevendanna approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assert that this PR is required.

@srenatus srenatus merged commit 7eac9ca into master Jul 11, 2019
@chef-ci chef-ci deleted the sr/authz-service/nitpick-postres-tests branch July 11, 2019 10:33
@susanev susanev added the auth-team anything that needs to be on the auth team board label Jul 20, 2019
@ekmixon ekmixon mentioned this pull request May 14, 2022
Open
@ekmixon ekmixon mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendanna stevendanna stevendanna approved these changes

Assignees

@srenatus srenatus

Labels
auth-team anything that needs to be on the auth team board automate-auth chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srenatus @stevendanna @susanev