Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we download cookbooks? #20

Closed
afiune opened this issue Oct 11, 2019 · 7 comments
Closed

Can we download cookbooks? #20

afiune opened this issue Oct 11, 2019 · 7 comments
Assignees
Labels
Status: Adopted An issue that is being worked on. Triage: Feature Request Indicates an issue requesting new functionality.

Comments

@afiune
Copy link

afiune commented Oct 11, 2019

As a chef-analyze developer,
I need to be able to download cookbooks from a Chef Server,
So I am able to analyze them and generate reports for our customers.

Acceptance Criteria

Create code that shows that it is possible to download a foo cookbook from a Chef Server.

@afiune afiune added the Status: Adopted An issue that is being worked on. label Oct 11, 2019
@afiune afiune self-assigned this Oct 11, 2019
@afiune
Copy link
Author

afiune commented Oct 14, 2019

I have diagnosed that there is no such functionality available at the community
repo https://github.com/go-chef/chef, which means that we will have to code
it ourselves. I am going to use this issue to track such work but in the meantime,
I have found a bug that is a blocker at this point, I have already created an issue
and worked on the solution:

GH Issue: go-chef/chef#112
GH PR: go-chef/chef#113

afiune pushed a commit that referenced this issue Oct 14, 2019
As a chef-analyze developer,
I need to be able to download cookbooks from a Chef Server,
So I am able to analyze them and generate reports for our customers.

Contributes #20

Signed-off-by: Salim Afiune <afiune@chef.io>
@tyler-ball tyler-ball added Aspect: Correctness Triage: Feature Request Indicates an issue requesting new functionality. labels Oct 14, 2019
@MarkGibbons
Copy link

I'll take a look at actually downloading cookbook files in the go-chef api.
I merged your change as v0.0.2 of the go-chef api.

@afiune
Copy link
Author

afiune commented Oct 15, 2019

@MarkGibbons thank you so much for merging that PR! Add chef, we are starting to work heavily with the Go language and therefore you will have a bunch of new features and bug fixes coming your way. For example, I already coded the cookbook download so I can easily contribute back to go-chef, what do you think about that?

@MarkGibbons
Copy link

Saves me a bunch of work. That would be a great addition.

One of my concerns is making sure the chef infra api documentation matches what actually happens and that the go-chef api matches the documentation. If you verify things actually work the way the code says it does and update the doc that will be a huge help.

@MarkGibbons
Copy link

One of the things I'm trying to do in order to do better testing is to spin up a real chef server and run the api against the real thing. It's surprising how many things turn up when testing against the real thing.

Thanks for the PRs and issues.

@tas50
Copy link
Contributor

tas50 commented Oct 15, 2019

@MarkGibbons there's some work on the chef server to spin up test environments. We'll see where that goes and we'd love to do whatever we can to make sure that sort of functionality is available for testing this library.

@afiune
Copy link
Author

afiune commented Oct 15, 2019

@MarkGibbons Here you have it go-chef/chef#115

tenor-45241418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Adopted An issue that is being worked on. Triage: Feature Request Indicates an issue requesting new functionality.
Projects
None yet
Development

No branches or pull requests

4 participants