[ctl-commands] Call reindex escript with absolute path #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 636b10d the configuration for the various erlang applications were changed to use `{include_erts, false}` as a release build option. It appears that a side effect of that change is that the start_clean.boot file in /opt/opscode/embedded/service/opscode-erchef/bin no longer points at the correct ERTS installation. Since that boot file is used automatically by erl when starting the command from that directory, the reindex command was failing to launch. This change avoid the problem by calling the reindex script with an absolute path. Alternatives would include reverting the include_erts change or determining how to configure rebar/relx such that the produced start_clean.boot file is correct. Signed-off-by: Steven Danna <steve@chef.io>
marcparadise
approved these changes
May 12, 2017
jaymalasinha
approved these changes
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 636b10d the configuration for the
various erlang applications were changed to use
{include_erts, false}as a release build option. It appears that a side effect ofthat change is that the start_clean.boot file in
/opt/opscode/embedded/service/opscode-erchef/bin
no longer points at the correct ERTS installation. Since that boot
file is used automatically by erl when starting the command from that
directory, the reindex command was failing to launch.
This change avoid the problem by calling the reindex script with an
absolute path. Alternatives would include reverting the include_erts
change or determining how to configure rebar/relx such that the
produced start_clean.boot file is correct.
Signed-off-by: Steven Danna steve@chef.io