Remove analytics plain text secrets when insecure_addon_compat false #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, secrets would be laid on disk, and kept being there when insecure_addon_compat was turned _off_. Now, those files will be deleted if it is turned off. Signed-off-by: Stephan Renatus <srenatus@chef.io>
stevendanna
approved these changes
Jun 14, 2017
Sgtpluck
approved these changes
Jun 16, 2017
srenatus
deleted the
sr/pool-590/remove-actions-password-when-insecure_addon_compat-is-false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, secrets would be laid on disk, and kept being there when
insecure_addon_compat was turned off. Now, those files will be deleted
if it is turned off.
Signed-off-by: Stephan Renatus srenatus@chef.io