Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error 'error validating X-Vault-AWS-IAM-Server-ID header: missing header X-Vault-AWS-IAM-Server-ID' in Hashi Vault secret manager for AWS IAM auth method #12956

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

neha-p6
Copy link
Collaborator

@neha-p6 neha-p6 commented Jun 1, 2022

Signed-off-by: Neha Pansare neha.pansare@progress.com

Description

The implementation uses vault-ruby gem and its Vault.auth.aws_iam method. (Refer chef/lib/chef/secret_fetcher/hashi_vault.rb for additional code details
Here the 3rd parameter iam_auth_header_value , which can be nil but if not passed, the gem throws the given error:
error validating X-Vault-AWS-IAM-Server-ID header: missing header X-Vault-AWS-IAM-Server-ID' in Hashi Vault secret manager for AWS IAM auth method

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

… header X-Vault-AWS-IAM-Server-ID' in Hashi Vault secret manager for AWS IAM auth method

Signed-off-by: Neha Pansare <neha.pansare@progress.com>
@neha-p6 neha-p6 requested review from a team as code owners June 1, 2022 11:27
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@neha-p6 neha-p6 merged commit e6486a5 into main Jun 7, 2022
@neha-p6 neha-p6 deleted the neha-p6/fix_iam_hashi_issue branch June 7, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants