Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't eval the action_class #146

Merged
merged 1 commit into from
May 13, 2020
Merged

Don't eval the action_class #146

merged 1 commit into from
May 13, 2020

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Mar 1, 2019

This shouldn't be necessarily in any supported Chef release.

Signed-off-by: Tim Smith tsmith@chef.io

@tas50 tas50 requested a review from a team March 1, 2019 02:04
@tas50 tas50 requested a review from a team as a code owner April 6, 2019 04:29
@tas50 tas50 force-pushed the eval branch 2 times, most recently from 25577e2 to 76e0d49 Compare April 25, 2019 04:09
@tas50
Don't eval the action_class
c45c1fe 
This shouldn't be necessarity in any supported Chef release.

Signed-off-by: Tim Smith <tsmith@chef.io>
stevendanna
stevendanna approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

If you happen to know when this became unnecessary, it might be good to throw that in the commit message.

@tas50 tas50 merged commit a440fb2 into master May 13, 2020
@tas50
Copy link
Contributor Author

tas50 commented May 13, 2020

~12.7

@chef-expeditor chef-expeditor bot deleted the eval branch May 13, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendanna stevendanna stevendanna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tas50 @stevendanna