Honor settings in recipes #25
Conversation
…setting as symbols then honor those. Fixes #163
| end | ||
|
|
||
| # Copy over to symbol key for things that use symbol keys... | ||
| options[symbol_key] = options[string_key] |
There was a problem hiding this comment.
I'm concerned that this will overwrite the symbol value with the string value, which is the opposite behavior of cheffish 0.7.x: https://github.com/opscode/cheffish/blob/v0.7.1/lib/cheffish/recipe_dsl.rb#L71
In my example I was passing :cookbook_path in and a "cookbook_path" was getting set automatically.
There was a problem hiding this comment.
In this case, the string value does take precedence, so if you have "cookbook_path" and :cookbook_path, then "cookbook_path" will win. I will flip-flop them for consistency with previous behavior ;) It's worth noting that your example will still work though, because if you don't have a string key of the same name, the symbol key will get propagated to the string key, and then all the merged values as string keys will also get set as symbol keys.
There was a problem hiding this comment.
We could also do
options[symbol_key] = options[string_key] unless options[symbol_key]to preserve the symbol_key if it isn't nil
Honor settings in recipes fixes #22
If the user has specified options in with_chef_local_server or other setting as symbols then honor those. Fixes #163