Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Base API breakage in Chef/Style/CommentSentenceSpacing #961

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix Base API breakage in Chef/Style/CommentSentenceSpacing #961

merged 1 commit into from
Jun 27, 2023

Conversation

dafyddcrosby
Copy link
Collaborator

@dafyddcrosby dafyddcrosby commented Jun 19, 2023 •
edited
Loading

Description

See
rubocop/rubocop@f8813e7

location no longer needed, in the "new" Base API (which came about in RuboCop 0.87). CommentSentenceSpacing is disabled by default, which is how it got missed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@dafyddcrosby dafyddcrosby requested review from a team as code owners June 19, 2023 10:59
@jaymzh jaymzh closed this Jun 27, 2023
@jaymzh jaymzh reopened this Jun 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jaymzh jaymzh merged commit c4c18c5 into chef:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymzh jaymzh jaymzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dafyddcrosby @jaymzh