Ruby upgrade to 3.3 #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
tpowell-progress
requested changes
Jul 16, 2024
| @@ -12,16 +12,16 @@ Gem::Specification.new do |spec| | |||
| spec.homepage = "https://github.com/chef/fauxhai" | |||
| spec.license = "MIT" | |||
|
|
|||
| spec.required_ruby_version = ">= 2.7" | |||
| spec.required_ruby_version = ">= 3.3" | |||
There was a problem hiding this comment.
Chef 18 supports 3.0 for AIX.
| @@ -11,7 +11,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| ruby: [ '2.7', '3.0', '3.1' ] | |||
| ruby: [ '3.3' ] | |||
There was a problem hiding this comment.
We still support 3.0 and 3.1.
|
|
||
| spec.files = %w{LICENSE Gemfile fauxhai-chef.gemspec} + Dir.glob("{lib,bin}/**/*", File::FNM_DOTMATCH).reject { |f| File.directory?(f) } | ||
| spec.executables = "fauxhai" | ||
| spec.require_paths = ["lib"] | ||
|
|
||
| spec.add_runtime_dependency "net-ssh" | ||
|
|
||
| spec.add_development_dependency "chef", ">= 13.0" | ||
| spec.add_development_dependency "ohai", ">= 13.0" | ||
| spec.add_development_dependency "chef", "~> 18.0" |
There was a problem hiding this comment.
I don't know that we should jump to ~> 18.0 _Maybe ">= 17.0"`
|
We need to have a discussion about how to go about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added ruby upgrade to 3.3
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.