Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#253] VPC: Server create fails if public IP but DNS hostnames disabled #253 #255

Merged
merged 1 commit into from
Oct 28, 2014
Merged

[#253] VPC: Server create fails if public IP but DNS hostnames disabled #253 #255

merged 1 commit into from
Oct 28, 2014

Conversation

prabhu-das
Copy link
Contributor

Issue ref: #253

@adamedx @muktaa

@prabhu-das prabhu-das mentioned this pull request Oct 21, 2014
Closed
@adamedx
Copy link

adamedx commented Oct 27, 2014

Looks good to me, let's merge.

muktaa pushed a commit that referenced this pull request Oct 28, 2014
Merge pull request #255 from ClogenyTechnologies/pd/fix-dns-name-not-…
a1032f5 
…exists-vpc

[#253] VPC: Server create fails if public IP but DNS hostnames disabled #253
@muktaa muktaa merged commit a1032f5 into chef:master Oct 28, 2014
@muktaa muktaa deleted the pd/fix-dns-name-not-exists-vpc branch October 28, 2014 06:38
@mrigeshpriyadarshi
Copy link

It looks like even though, the fix is merged. It is not available in "0.10.0" build. We can still see the old code.

@siddheshwar-more
Copy link

@mrigeshpriyadarshi
PR changes exists in master branch.
I think, when 0.10.0 was released at that time this PR not merged into release branch i.e created for "0.10.0" build.

@mrigeshpriyadarshi
Copy link

@siddheshwar-more
True. That's what I was pointing. when are we planning for next build release. Also, with this release, there is an issue with nokogiri dependency. It tries to install nokogiri-1.6.6.2, which fails at gem build.

@NimishaS NimishaS mentioned this pull request Jun 10, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prabhu-das @adamedx @mrigeshpriyadarshi @siddheshwar-more @muktaa