[mdadm] Handle inactive arrays correctly #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lamont-granquist - did you guys move to a new chefstyle/rubocop? The entire codebase is suddenly failing style checks. :( |
|
yeah i just released a new chefstyle because it needed a rubocop engine upgrade to agree with cookstyle's pinned rubocop version. the engine upgrade changed the behavior of a few rules. |
|
oh heh, seems i had some chefstyle rules queued up on master that i forgot all about.... |
|
#1018 should have fixed that. |
Currently we don't handle inactive arrays correctly, this will do so better. Tests included. Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
force-pushed
the
fix_mdadm_inactive
branch
from
bba2738
to
0d030e5
Compare
|
Fixing leftover... chefstyle issues |
tas50
approved these changes
Jun 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we don't handle inactive arrays correctly, this will do so better.
Tests included.
Signed-off-by: Phil Dibowitz phil@ipom.com
Issues Resolved
Inactive arrays reported without members.
Check List