Add Arch Linux support to package plugin #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dang, I wasn't aware of chefstyle. Let me make some changes and try again. |
tas50
reviewed
Sep 7, 2017
lib/ohai/plugins/packages.rb
Outdated
| @@ -31,6 +31,7 @@ | |||
| end | |||
|
|
|||
| collect_data(:linux) do | |||
| require "date" | |||
There was a problem hiding this comment.
Can you move this into the Arch section since it's not needed for the other platforms
tas50
reviewed
Sep 7, 2017
lib/ohai/plugins/packages.rb
Outdated
| @@ -31,6 +31,7 @@ | |||
| end | |||
|
|
|||
| collect_data(:linux) do | |||
| require "date" | |||
| packages Mash.new | |||
| if %w{debian}.include? platform_family | |||
There was a problem hiding this comment.
Any chance you can change these platform_family checks into a case statement. At 3 different checks of the same data it would be faster to use a single check in a case statement
|
Overall this looks pretty solid. Thanks for putting it together. Just fix those 2 comments and this is good to go. |
Signed-off-by: William Osler <oslerw@fb.com>
|
Looks good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds support for detecting packages on Arch Linux. This is my first time contributing to Ohai or any Chef project, so I'd appreciate any feedback.
Issues Resolved
I wrote this mainly because I wanted to make some decisions in Chef that involved knowing if one package from a set were already installed. Specifically, I wanted a recipe that installs command line vim, but only if graphical vim isn't already installed.
Check List