Add error handling in Linux filesystem plugin #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Asuncion <jeunito@gmail.com>
Signed-off-by: Jose Asuncion <jeunito@gmail.com>
|
Instead of performing the which before the shell_out (which does the which again) could you look into rescuing the shell_out exceptions. We do that for a lot of the language plugins. It avoids a pile of disk IO every time we run the plugin. |
Signed-off-by: Jose Asuncion <jeunito@gmail.com>
|
@tas50 ok. I have changed the implementation |
tas50
approved these changes
Sep 6, 2017
|
Thanks |
|
No problem
…On Sep 6, 2017 7:17 AM, "Tim Smith" ***@***.***> wrote:
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1047 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABKOf1ZWDDKfoN2MNe4p2KViXjjUtIa8ks5sfqllgaJpZM4O_cmV>
.
|
|
This is actually super terrifying. If I'm not a fan of this. I'm actually going to make a PR to make this optional and default to failing the plugin. |
jaymzh
added a commit
to jaymzh/ohai
that referenced
this pull request
Oct 3, 2017
PR chef#1047 allows a plugin to return partial data which may be incredibly dangerous. It's a totally reasonable thing to want, however, so we gate it behind a plugin config. However, the default behavior reverts to where it was. Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
added a commit
to jaymzh/ohai
that referenced
this pull request
Oct 4, 2017
PR chef#1047 allows a plugin to return partial data which may be incredibly dangerous. It's a totally reasonable thing to want, however, so we gate it behind a plugin config. However, the default behavior reverts to where it was. Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
added a commit
to jaymzh/ohai
that referenced
this pull request
Oct 5, 2017
PR chef#1047 allows a plugin to return partial data which may be incredibly dangerous. It's a totally reasonable thing to want, however, so we gate it behind a plugin config. However, the default behavior reverts to where it was. Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
added a commit
that referenced
this pull request
Oct 5, 2017
PR #1047 allows a plugin to return partial data which may be incredibly dangerous. It's a totally reasonable thing to want, however, so we gate it behind a plugin config. However, the default behavior reverts to where it was. Signed-off-by: Phil Dibowitz <phil@ipom.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add error handling in Linux filesystem plugin for when a command does not exist.
Issues Resolved
#1011