Detect Rackspace on Windows #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderanger
approved these changes
Sep 21, 2017
| if wmi.first_of("Win32_ComputerSystem")["PrimaryOwnerName"] == "Rackspace" | ||
| Ohai::Log.debug("Plugin Rackspace: has_rackspace_manufacturer? == true") | ||
| return true | ||
| end |
There was a problem hiding this comment.
Should have a final false for good measure :)
There was a problem hiding this comment.
Nil evals perfectly here and this is the same pattern we're using in all our other methods
tas50
force-pushed
the
rackspace_windows
branch
from
4acfcd4
to
d1e62d0
Compare
This uses the same method we previously used on EC2. It won't poll any data since that requires the xen cli tools, but it will show up as being on rackspace, which is an important first step. Signed-off-by: Tim Smith <tsmith@chef.io>
All we have is the main rackspace attribute and since we're checking ruby versions in the method we can't really mock out the wmi stuff. Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
rackspace_windows
branch
from
d1e62d0
to
12a82f5
Compare
lamont-granquist
approved these changes
Oct 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same method we previously used on EC2. It won't poll any data since that requires the xen cli tools, but it will show up as being on rackspace, which is an important first step.