Fix bug in azure plugin/update to recent metadata version. #1154
Conversation
In Azure, receiving the network section of the JSON output is not guaranteed, and will crash this plugin in these cases.
New info includes resourceGroupName, availability zone info, subscriptionId, and VMSS info.
|
@kriszentner Thanks for taking the time to refactor this all. I'd love to get this into Chef 13/14. Can you run Thanks, |
lib/ohai/mixin/azure_metadata.rb
Outdated
| @@ -22,7 +22,7 @@ module Mixin | |||
| module AzureMetadata | |||
|
|
|||
| AZURE_METADATA_ADDR = "169.254.169.254" unless defined?(AZURE_METADATA_ADDR) | |||
| AZURE_METADATA_URL = "/metadata/instance?api-version=2017-04-02" unless defined?(AZURE_METADATA_URL) | |||
| AZURE_METADATA_URL = "/metadata/instance?api-version=2017-12-01" unless defined?(AZURE_METADATA_URL) | |||
There was a problem hiding this comment.
In the ec2 metadata resource we have some magic that looks for the latest supported metadata from an array of known supported versions. Do you think we should maybe look at doing something like that here or are we guaranteed to always have 2017-12-01?
There was a problem hiding this comment.
I looked at the documentation and it seems that they support older versions as they age. I'll have to look into seeing if there's a per instance api version checker. Maybe I can bug someone in Azure. I found 12-01 isn't supported in UK so I backed it off to the one that's supported everywhere.
|
@kriszentner There's a rspec failure if you check the Travis/Appveyor runs |
Was missing passing metadata to the network metadata initialization function
|
This looks good to me. We just need the DCO signoff on the commits so we can accept it. There's details here: https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco |
In Azure, receiving the network section of the JSON output is not guaranteed, and will crash this plugin in these cases. Signed-off-by: Kris Zentner <krisz@microsoft.com>
New info includes resourceGroupName, availability zone info, subscriptionId, and VMSS info. Signed-off-by: Kris Zentner <krisz@microsoft.com>
This is documented here: https://docs.microsoft.com/en-us/azure/virtual-machines/windows/instance-metadata-service Signed-off-by: Kris Zentner <krisz@microsoft.com>
Signed-off-by: Kris Zentner <krisz@microsoft.com>
Was missing passing metadata to the network metadata initialization function Signed-off-by: Kris Zentner <krisz@microsoft.com>
Signed-off-by: Kris Zentner <krisz@microsoft.com>
|
Thanks for helping me out with this. Learn something new every time when doing these contribs! |
|
Thanks for working through it. This is a nice step in the right direction for how we handle this metadata. |
Fix bug in azure plugin/update to recent metadata version. [ backport #1154]
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This fixes a bug discovered for the Azure plugin, and updates to the recent azure metadata api date/version.
Issues Resolved
This fixes a bug I discovered which will crash the azure plugin if it's missing metadata. I discovered, at least on an ND24rs instance I was on, that no network metadata is received.
Also updated to the recent Azure metadata API which gives additional metadata including the resource group name, availability set info, subscription id, and VM scale set info.