Unify the cpu plugin #1262
Merged
Unify the cpu plugin #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymzh
force-pushed
the
unify_cpu_plugin
branch
from
c2d10f3
to
1b49feb
Compare
Utilize the Ohai 7 syntax to keep the code for all these variations of the plugin in the same place and consistent. Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
force-pushed
the
unify_cpu_plugin
branch
from
1b49feb
to
2a32b86
Compare
tas50
approved these changes
Oct 4, 2018
|
Another 100 lines down! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Utilize the Ohai 7 syntax to keep the code for all these variations of the plugin in the same place and consistent.
In this case I kept the specs in separate files since there's no actual overlap in tests AFAICT and each platform's tests are exceptionally complicated, it's cleaner to leave them separate.
Signed-off-by: Phil Dibowitz phil@ipom.com
Check List