Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces require_relative with require #1349

Merged
merged 2 commits into from
Apr 22, 2019

Conversation

burtlo
Copy link

@burtlo burtlo commented Apr 13, 2019

Description

RSpec automatically adds the spec directory to the $LOAD_PATH so it is
not necessary to find the spec_helper with complicated path.

Signed-off-by: Franklin Webber franklin.webber@gmail.com

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • A non-essential change

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

RSpec automatically adds the spec directory to the $LOAD_PATH so it is
not necessary to find the spec_helper with complicated path.

Signed-off-by: Franklin Webber <franklin.webber@gmail.com>
@tas50
Copy link
Contributor

tas50 commented Apr 13, 2019

Seems like a nice way to simplify a lot of this. Can you run chefstyle on the PR to fix the warnings in travis?

Signed-off by: Franklin Webber <franklin.webber@gmail.com>
@tas50 tas50 merged commit 8c65304 into chef:master Apr 22, 2019
@tas50
Copy link
Contributor

tas50 commented Apr 22, 2019

Thanks @burtlo

@lock
Copy link

lock bot commented Jun 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants