Avoid constant warnings in windows/filesystem plugin #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenspider
reviewed
May 3, 2019
| @@ -24,7 +24,7 @@ | |||
| # @see https://docs.microsoft.com/en-us/windows/desktop/SecProv/getconversionstatus-win32-encryptablevolume#parameters | |||
| # | |||
| CONVERSION_STATUS = %w{FullyDecrypted FullyEncrypted EncryptionInProgress | |||
| DecryptionInProgress EncryptionPaused DecryptionPaused}.freeze | |||
| DecryptionInProgress EncryptionPaused DecryptionPaused}.freeze unless defined?(CONVERSION_STATUS) | |||
There was a problem hiding this comment.
- I feel like this is a bandaid that hides a problem in
plugin.rb(NamedPlugin.pluginis where this seems to be coming from). - You can change that to
||=instead ofunless defined?
There was a problem hiding this comment.
I updated this to improve our bandaid to use ||= everywhere
This is very noisy in DK specs. Signed-off-by: Tim Smith <tsmith@chef.io>
This is a lot easier to read. Signed-off-by: Tim Smith <tsmith@chef.io>
btm
approved these changes
Jun 3, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very noisy in DK specs.
Signed-off-by: Tim Smith tsmith@chef.io