Use virtualization attributes to run or skip the virtualbox plugin #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of attempting to shellout on every system we can just check the attributes we already have. This is slightly faster and improves logging since you won't see a failure. Signed-off-by: Tim Smith <tsmith@chef.io>
This is simpler and faster Signed-off-by: Tim Smith <tsmith@chef.io>
Just rely on the existing ohai data Signed-off-by: Tim Smith <tsmith@chef.io>
|
Thanks @robbkidd |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of attempting to shellout on every system we can just check the attributes we already have. This is slightly faster and improves logging since you won't see a failure.
Signed-off-by: Tim Smith tsmith@chef.io