Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify how we create empty mashes in the plugins #1374

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Simplify how we create empty mashes in the plugins #1374

merged 2 commits into from
Jun 13, 2019

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jun 12, 2019

This is a lot easier to read.

Signed-off-by: Tim Smith tsmith@chef.io

This is a lot easier to read.

Signed-off-by: Tim Smith <tsmith@chef.io>
Copy link
Contributor

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix to a Mash.new then I think it's good to go.

Interesting that the test suite doesn't check the right-side of these ORs, but yes, ||= is more better.

Signed-off-by: Tim Smith <tsmith@chef.io>

Co-Authored-By: Robb Kidd <robb@thekidds.org>
@tas50 tas50 merged commit 4f35261 into master Jun 13, 2019
@chef-ci chef-ci deleted the mash_new branch June 13, 2019 18:31
@lock
Copy link

lock bot commented Aug 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants