Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an internal reference to blacklist #1468

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Remove an internal reference to blacklist #1468

merged 2 commits into from
Jun 17, 2020

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jun 6, 2020

It's past time for this term to go away, even when it's just the name of
a method.

Signed-off-by: Tim Smith tsmith@chef.io

@tas50
Remove an internal reference to blacklist
c93645b 
It's past time for this term to go away, even when it's just the name of
a method.

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 requested review from a team as code owners June 6, 2020 19:35
phiggins
phiggins approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@phiggins phiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pry-stack_explorer dropped support for ruby < 2.6 so the ruby 2.5 task is failing, not sure what's going on with the windows task.

@tas50
Pin pry-stack_explorer for tests
09946ce 
Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 added the Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. label Jun 17, 2020
@tas50 tas50 merged commit 9174496 into master Jun 17, 2020
@chef-expeditor chef-expeditor bot deleted the blocklist branch June 17, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phiggins phiggins phiggins approved these changes

Assignees
No one assigned
Labels
Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tas50 @phiggins