Migrate to the chef-utils helpers for which/shell_out #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the which/shell_out helpers with ones from chef-utils. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
The default paths algorithm is a little bit weird Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
there's some test failures around the silly PATH mangling, i'll have to fix them later... |
tas50
reviewed
Aug 22, 2020
tas50
reviewed
Aug 22, 2020
tas50
reviewed
Aug 22, 2020
tas50
reviewed
Aug 22, 2020
tas50
reviewed
Aug 22, 2020
tas50
changed the title
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
we need to call out to the ChefConfig helper to set this Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
This throws warnings, but I'm a bit out of ideas today. This lies like crazy to make it work on windows. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
tas50
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the which/shell_out helpers with ones from chef-utils.
This moves the helpers to
mixin/shell_outandmixin/whichto better mirror chef's usage. It leaves aliases in the old locations. I don't see anything outside of the plugin DSL which references those so don't think it'd be breaking to remove them entirely, at the same time it is exceptionally cheap to leave the aliased constants in for backcompat.There's a few changes here which may be user visible: