Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: populate pause frame config #1564

Merged
merged 1 commit into from
Dec 23, 2020
Merged

network: populate pause frame config #1564

merged 1 commit into from
Dec 23, 2020

Conversation

kuba-moo
Copy link

@kuba-moo kuba-moo commented Nov 9, 2020 •
edited
Loading

Query via ethtool and populate information whether the node
has pause frames enabled or not.

Description

To be able to configure pause parameters its useful to have access
to current settings.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@kuba-moo kuba-moo requested review from a team as code owners November 9, 2020 21:44
@phiggins
Copy link
Contributor

phiggins commented Nov 10, 2020 •
edited
Loading

Hi, thanks for your contribution!

  • You'll need to complete the DCO signoff process in order for these changes to be accepted. If you're using a relatively recent version of git, you can do this with git rebase origin/master --signoff and then force pushing your branch.
  • It looks like this plugin has tests for the other sets of data collected, so it'd be good to add some tests for this new code to guard against future regressions: https://github.com/chef/ohai/blob/3ed8ec8524c52ccda346b7de35a949c4a1162b0b/spec/unit/plugins/linux/network_spec.rb
  • There's a few lint violations in here, which you can fix by running chefstyle -a.

phiggins
phiggins approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@phiggins phiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but otherwise looks good to me. 👍

@kuba-moo
network: populate pause frame config
1994d04 
Query via ethtool and populate information whether the node
has pause frames enabled or not.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
@tas50 tas50 merged commit e90cf86 into chef:master Dec 23, 2020
@tas50
Copy link
Contributor

tas50 commented Dec 23, 2020

Thanks @kuba-moo

@tas50 tas50 mentioned this pull request Feb 2, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phiggins phiggins phiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuba-moo @phiggins @tas50