Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub2: add plugin to expose GRUB2 environment variables #1590

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

davide125
Copy link
Contributor

Description

Add a basic plugin to expose GRUB2 environment variables. This is useful for example if one needs to manage the default kernel and/or its options on modern systems using EFI and BLS, but it will also work properly (and return useful data) on older systems.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@davide125 davide125 requested review from a team as code owners December 4, 2020 21:38
Copy link
Collaborator

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor stuff. looks good in general, thanks for writing tests.

lib/ohai/plugins/linux/grub2.rb Outdated Show resolved Hide resolved
lib/ohai/plugins/linux/grub2.rb Outdated Show resolved Hide resolved
lib/ohai/plugins/linux/grub2.rb Outdated Show resolved Hide resolved
lib/ohai/plugins/grub2.rb Outdated Show resolved Hide resolved
spec/unit/plugins/grub2_spec.rb Outdated Show resolved Hide resolved
Signed-off-by: Davide Cavalca <dcavalca@fb.com>
@tas50 tas50 merged commit 95ac2ff into chef:master Dec 4, 2020
facebook-github-bot pushed a commit to facebook/chef-cookbooks that referenced this pull request Dec 9, 2020
Summary:

Add some basic infrastructure to manage the grub environment for
GRUB2. This is especially useful on BLS systems, as the environment is what
defines the default kernel that will be booted. Depends on
chef/ohai#1590 to actually work.

Reviewed By: nikitakoshikov

Differential Revision: D25348955

fbshipit-source-id: 6a1222cb85926589f306df40da41f321cd7386b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants