Ohai: Change C language plugin for glibc version detection #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like you're missing the DCO sign-off and the |
It's not safe to directly execute "libc.so.6" to determine glibc version. This can lead to segfaults when other shared libraries are preloaded using LD_PRELOAD or /etc/ld.so.preload due to circular relocation dependencies. Replace this version detection with "ldd --version" as "ldd" is a core part of glibc and reports the same version. Signed-off-by: Bhavesh Davda <bhavesh.davda@oracle.com>
bhaveshdavda
force-pushed
the
ohai-glibc-bhavesh.davda@oracle.com
branch
from
a1a73a9
to
479ec99
Compare
|
Hi community, can someone please help me with the unit test validation failures? I'm completely unfamiliar with this project and can't quite tell how to modify |
added 2 commits
March 25, 2021 16:21
Replace invocation of libc.so.6 with "ldd --version" instead Signed-off-by: Bhavesh Davda <bhavesh.davda@oracle.com>
…glibc Signed-off-by: Bhavesh Davda <bhavesh.davda@oracle.com>
bhaveshdavda
force-pushed
the
ohai-glibc-bhavesh.davda@oracle.com
branch
from
1927888
to
426f585
Compare
|
Wild! I hacked my way through passing the unit tests :-) Waiting for some reviews now. |
lamont-granquist
approved these changes
Apr 5, 2021
|
cool, this LGTM. |
|
Thank you for your review, as well as merging the change, @lamont-granquist ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not safe to directly execute "libc.so.6" to determine glibc version.
This can lead to segfaults when other shared libraries are preloaded using
LD_PRELOAD or /etc/ld.so.preload due to circular relocation dependencies.
Replace this version detection with "ldd --version" as "ldd" is a core part
of glibc and reports the same version.
Description
Related Issue
Types of changes
Checklist: