Network: Record xdp data from ip link. #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recording the xdp data - mode, id and tag from the ip link output. This data is recorded within the iface hash while gathering link statistics. Added unit tests under network_spec.rb for all cases. Signed-off-by: Zeeshan Lokhandwala <zeeshanl@fb.com>
lamont-granquist
approved these changes
Feb 3, 2022
|
@tas50 you got any thoughts? i don't see anything wrong here but its well outside of my domain knowledge. |
jaymzh
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording the xdp data - mode, id and tag from the ip link output.
This data is recorded within the iface hash while gathering link statistics.
Added unit tests under network_spec.rb for all cases.
Signed-off-by: Zeeshan Lokhandwala zeeshanl@fb.com
Description
Currently we do not have access to the XDP information contained in the ip link output. This patch records the xdp mode, id and tag. This will allow chef to know whether xdp is enabled and in which mode allowing the user to define specific network settings.
Related Issue
#1729
Types of changes
Checklist: