WIP: Fix detection of mac address on IPv6 systems #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| ip6address route[:src] | ||
| end | ||
| else | ||
| macaddress iface[default_route[:dev]][:addresses].select{|k,v| v["family"]=="lladdr"}.first.first unless iface[default_route[:dev]][:flags].include? "NOARP" |
There was a problem hiding this comment.
in the event routes were found, this won't fill in mac addr, right?
|
Ping? |
|
Sorry @jaymzh I've been out with the flu. Still recoverying |
| unless route.nil? or route.empty? | ||
|
|
||
| if route && !route.empty? | ||
| macaddress iface[route[:dev]][:addresses].select{|k,v| v["family"]=="lladdr"}.first.first unless iface[route[:dev]][:flags].include? "NOARP" |
There was a problem hiding this comment.
I think this is fine, but ftr, if you have v4 and v6 routes that match, v6 will win since it's done second.
|
Closing this out since @btm picked up the slack from my deathly illness and finished this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We failed to detect the mac address when lo has ipv4/ipv6, but all other interfaces only have ipv6. This is just a simplified version of Phil's code from #685 with specs added.