Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments and minor cleanup of network and network specs #694

Closed
wants to merge 1 commit into from

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Dec 22, 2015

Expand network interface mock data for readability
&& vs. and
opscode -> Chef inc.
Remove extra spaces in specs
Improve debug output
Add comments to methods

@tas50
Copy link
Contributor Author

tas50 commented Dec 22, 2015

@thommay and @lamont-granquist I'm breaking all the minor cleanup changes out of the ipv6 fixes.

@jaymzh
Copy link
Collaborator

jaymzh commented Dec 22, 2015

tests fail, but I'm 👍 in general

Expand network interface mock data for readability
&& vs. and
opscode -> Chef inc.
Remove extra spaces in specs
Improve debug output
Add comments to methods
@tas50
Copy link
Contributor Author

tas50 commented Dec 22, 2015

Tests are passing on this one branch

@tas50
Copy link
Contributor Author

tas50 commented Dec 23, 2015

This can be closed out since the changes are part of @btm's changes in #695

@tas50 tas50 closed this Dec 23, 2015
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants