Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Azure using the Azure agent and DHCP options #714

Merged
merged 3 commits into from
Feb 9, 2016

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Feb 2, 2016

Azure has no metadata endpoint and we pass in everything we stick in the mash via the hint, but there's still value in detecting azure when we didn't knife bootstrap. Users still want to do different things on their cloud hosts and this gives them that ability.

  1. Detect hosts as being on azure when the waagent is present (windows and linux)
  2. Detect hosts as being on azure when we find unknown-245 dhcp option which is used by Azure (linux only)
  3. Fix the specs for the lack of hint file or presence of rackspace hint file so they actually run. This confused me for a while until I realized they were expecting nil and not running the plugin so they got nil. Ouch.

And a bonus commit: switch the order or MS virtualization detection since 99.9% of the time it's hyper-v. No point in checking for VirtualPC first only to skip it 99.9% of the time.

Start with the most likely value to avoid checking for virtualpc first each time
@tas50
Copy link
Contributor Author

tas50 commented Feb 2, 2016

@chef/client-core ready for review

@thommay
Copy link
Contributor

thommay commented Feb 3, 2016

LGTM 👍

@smurawski
Copy link
Contributor

👍 until we get a metadata endpoint in azure. There may be conflicts for folks migrating between on-prem and azure, but that's a pretty minimal case.

tas50 added a commit that referenced this pull request Feb 9, 2016
Detect Azure using the Azure agent and DHCP options
@tas50 tas50 merged commit ec92e22 into chef:master Feb 9, 2016
@tas50 tas50 deleted the azure_detection branch February 9, 2016 17:50
@thommay thommay added Type: Enhancement Adds new functionality. and removed Enhancement labels Jan 24, 2017
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants