Update GCE metadata API version and fail better #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the non-beta metadata URL. This requires setting the header on all requests so there's a bit of changes to how the http connection is initialized Fail better if the google internal DNS name can't be resolved
|
Looks legit but you'll need to update your tests. |
|
Yep |
|
Fixes #382 |
|
@chef/client-core This is ready for review |
|
👍 @chef/client-core |
|
👍 |
tas50
added a commit
that referenced
this pull request
Mar 9, 2016
Update GCE metadata API version and fail better
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the non-beta metadata URL. This requires setting the header on all requests so there's a bit of changes to how the http connection is initialized
Fail better if the google internal DNS name can't be resolved