Improve virtualization detection on Solaris #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 6, 2016
Copy and past from Linux Virtualization plugin
Linux / BSD use 'Product Name:' while Solaris uses 'Product:' Product.*: should be just fine
This way anything we add for Linux will automatically get added to Solaris as well. We're already using this in *BSD as well. This will add Hyper-V, KVM, Xen, VirtualServer, VirtualBox, and Openstack detection. Not bad for a net reduction in code.
We'll want a few more tests to be added here
tas50
force-pushed
the
solaris_needs_virt_love
branch
from
44784c0
to
56eca06
Compare
|
👍 |
1 similar comment
|
👍 |
tas50
added a commit
that referenced
this pull request
Mar 9, 2016
Improve virtualization detection on Solaris
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect additional paravirt KVM CPU strings:
Use the same node[:virtualization][:systems] multiple virtualization system attribute structure we use on other systems
Use our shared DMI Decode library for detection virtualization systems. This adds detection for Solaris running on the following systems: