Correct the version detection in erlang plugin #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't correctly identifying the erlang version. Instead we were detecting the erts version.
Old result:
```javascript
"erlang": {
"version": "7.3",
"options": [
"SMP",
"ASYNC_THREADS",
"HIPE"
],
"emulator": "BEAM"
},
```
New result
```javascript
"erlang": {
"version": "18",
"erts_version": "7.3",
"nif_version": "2.10",
"options": [
"SMP",
"ASYNC_THREADS",
"HIPE"
],
"emulator": "BEAM"
},
```
tas50
changed the title
|
This is ready for review @chef/client-core @mcquin |
|
Nice! 👍 |
Merged
| options = output[1] | ||
| options.gsub!(/(\(|\))/, "") | ||
| erlang[:options] = options.split(",") | ||
| erlang[:emulator] = output[2].gsub!(/(\(|\))/, "") |
There was a problem hiding this comment.
might consider using delete instead of gsub
|
I'm 👍 you can take my nit or leave it. |
|
I'll get that fixed up on my general plugin cleanup branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't correctly identifying the erlang version. Instead we were detecting the erts version.
Old result:
New result