Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installs on Ruby 2.1 and rspec testing with rspec 3.5 #861

Merged
merged 4 commits into from
Aug 11, 2016
Merged

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Aug 10, 2016

Bump github changelog generator the the latest, constrain rack to < 2 and fix a require in the spec helper that is causing failures in rspec 3.5. Get the build green again basically

Signed-off-by: Tim Smith tsmith@chef.io

github_changelog_generator 1.13.1 bumps the github api to a version that
contrains rack to allow for Ruby 2.1 installs.

Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 changed the title Fix install on Ruby 2.1 by bumping github_changelog_generator Fix installs on Ruby 2.1 and rspec testing with rspec 3.5 Aug 11, 2016
@thommay thommay merged commit 5aae671 into master Aug 11, 2016
@tas50 tas50 added the Bug label Aug 11, 2016
@tas50 tas50 deleted the rack_fix branch August 11, 2016 20:34
@thommay thommay added Type: Bug Does not work as expected. and removed Bug labels Jan 24, 2017
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants