Properly detect Cumulus Linux platform / version #921
Conversation
tas50
force-pushed
the
cumulus
branch
6 times, most recently
from
2357617
to
3106626
Compare
Detect cumulus Linux systems if they have /etc/cumulus directory. Use platform of ‘cumulus’ and platform_family debian since it’s Debian 8.5. Parse version from their config directory. Signed-off-by: Tim Smith <tsmith@chef.io>
| @@ -187,6 +225,12 @@ | |||
| expect(@plugin[:platform]).to eq("slackware") | |||
| expect(@plugin[:platform_family]).to eq("slackware") | |||
| end | |||
|
|
|||
| it "should set platform_version on slackware" do | |||
There was a problem hiding this comment.
This was missing so I figured I should add it while I was here
tas50
changed the title
Signed-off-by: Tim Smith <tsmith@chef.io>
Check the more popular platforms first since those are most likely to match. Parallels have to come before RHEL though since it looks like RHEL. Signed-off-by: Tim Smith <tsmith@chef.io>
| if platform == "cumulus" | ||
| if File.exist?("/etc/cumulus/etc.replace/os-release") | ||
| release_contents = File.read("/etc/cumulus/etc.replace/os-release") | ||
| release_contents.match(/VERSION_ID=(.*)/)[1] rescue nil |
There was a problem hiding this comment.
maybe you want the warning below here as well instead of a nil rescue
There was a problem hiding this comment.
Probably. I keep going back and forth with how much Ohai should warn when things don't go right. Recently leaning more to towards Ohai being verbose when things fail so that people see that things are failing and file issues. We have a lot of hidden failures right now, which doesn't help anyone.
There was a problem hiding this comment.
I fully support you doing the right thing, whatever that is.
|
@btm does that last commit work for you? |
Signed-off-by: Tim Smith <tsmith@chef.io>
| end | ||
|
|
||
| # | ||
| # Determines the platform_family based on the platform_family |
There was a problem hiding this comment.
I like my wording better ;)
There was a problem hiding this comment.
Determines the platform_family based on the platform family? :)
Signed-off-by: Tim Smith <tsmith@chef.io>
Description
Detect cumulus Linux systems if they have /etc/cumulus directory. Use platform of ‘cumulus’ and platform_family debian since it’s Debian 8.5. Parse version from their config directory.
Issues Resolved
N/A
Check List