Improve debug logging in multiple plugins #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
force-pushed
the
better_logging
branch
from
7f5b51b
to
f5370a7
Compare
thommay
reviewed
Dec 22, 2016
| end | ||
| end | ||
| rescue Ohai::Exceptions::Exec | ||
| Ohai::Log.debug('Plugin Virtualbox: Could not shell_out "VBoxControl guestproperty enumerate". Skipping data') |
There was a problem hiding this comment.
"execute" rather than "shell_out"?
thommay
approved these changes
Dec 22, 2016
Gracefully fail in virtual box Include plugin name in more logs Be consistent in the log output format Help figure out how Virtualization systems were detected with logging Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
better_logging
branch
from
f5370a7
to
705e622
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully fail in virtual box
Include plugin name in more logs
Be consistent in the log output format
Help figure out how Virtualization systems were detected with logging