Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ec2] Add additional data from identity document #964

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

webframp
Copy link
Contributor

Description

Include the region and availability zone as information retrieved from the identity document. Since it's already fetching the identity document to retrieve the account id, this just adds the additional info from the same source.

Other properties could also be included but these were the two I needed most.

Issues Resolved

None that I know of

Check List

Since it's already fetching the identity document to retrieve the account id,
this adds the region and AZ info in the same place.

Signed-off-by: Sean Escriva <sean.escriva@gmail.com>
Copy link
Contributor

@thommay thommay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gif-keyboard-17938522176461203604

@tas50
Copy link
Contributor

tas50 commented Mar 22, 2017

Not sure if placement_availability_zone and availability_zone ever differ, but I guess we have both now. Thanks for the fix

@tas50 tas50 merged commit bda5683 into chef:master Mar 22, 2017
@tas50 tas50 added the Type: Enhancement Adds new functionality. label Mar 22, 2017
tas50 added a commit that referenced this pull request May 8, 2017
[ec2] Add additional data from identity document
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants