Replace the cloud plugin with the cloud_v2 plugin #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply set the cloud_v2 plugin to to write to both namespaces Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
spec/unit/plugins/cloud_v2_spec.rb
Outdated
| it "populates cloud public ip" do | ||
| @plugin.run | ||
| expect(@plugin[:cloud_v2]).to_not be_nil | ||
| expect(@plugin[:cloud]).to_not be_nil |
There was a problem hiding this comment.
same here maybe check they're both equal.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
@lamont-granquist Fixed it for you |
coderanger
approved these changes
Apr 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cloud plugin is the first thing a user would see and new users would gravitate to that plugin. The plugin format is flawed though and we long ago replaced it with cloud_v2. This plugin removes the exist cloud plugin and instead has the cloud_v2 plugin write to both node['cloud'] and node['cloud_v2']. This is going to need an additional test to ensure we get data in both namespaces.
Signed-off-by: Tim Smith tsmith@chef.io