Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenStack plugin to use the HttpHelper mixin #986

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Fix OpenStack plugin to use the HttpHelper mixin #986

merged 1 commit into from
Apr 9, 2017

Conversation

akitada
Copy link
Contributor

@akitada akitada commented Apr 9, 2017 •
edited
Loading

Description

"can_metadata_connect?" has been renamed to "can_socket_connect?" and
moved into the HttpHelper mixin. (#951)

This patch fixes OpenStack plugin to use the HttpHelper mixin.

Issues Resolved

N/A

Check List

@akitada
Fix OpenStack plugin to use the HttpHelper mixin
eb214de 
"can_metadata_connect?" has been renamed to "can_socket_connect?" and
moved into the HttpHelper mixin.

Signed-off-by: Akira Kitada <akitada@gmail.com>
@tas50 tas50 merged commit d880c8a into chef:master Apr 9, 2017
@tas50
Copy link
Contributor

tas50 commented Apr 9, 2017

Thanks for spotting this

@akitada akitada deleted the fix_openstack branch April 9, 2017 17:54
@akitada akitada mentioned this pull request Apr 11, 2017
Merged
4 tasks
@tas50 tas50 added the Type: Bug Does not work as expected. label Apr 11, 2017
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Does not work as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akitada @tas50