Inject sane paths into shell_out #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akitada
force-pushed
the
linux_net_cmds_path
branch
4 times, most recently
from
8be12ed
to
6cdfc4f
Compare
|
@akitada Thanks for taking a stab at this. You'll need to make sure the which command in the specs actually returns the expected data. It works on *nix systems that actually have those commands, but the specs blow up on Windows systems where we're autofilling "false" |
akitada
force-pushed
the
linux_net_cmds_path
branch
from
6cdfc4f
to
172d23c
Compare
akitada
changed the title
akitada
force-pushed
the
linux_net_cmds_path
branch
2 times, most recently
from
74d5358
to
68c1691
Compare
To ensure shell_out can find binaries. Signed-off-by: Akira Kitada <akitada@gmail.com>
akitada
force-pushed
the
linux_net_cmds_path
branch
from
68c1691
to
7c969e1
Compare
akitada
changed the title
|
@tas50 Updated patch to inject sane paths, as in shell_out in Chef. |
|
Thanks for putting this together |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ohai network plugin for Linux fails to collect network related attributes
when networking commands like ip, route, ifconfig and arp are not in the $PATH.
Issues Resolved
#990
Check List