Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c-s-c show-versions subcommand for master #19

Closed
wants to merge 1 commit into from

Conversation

sean-horn
Copy link

We should have a way to output the versions of components present on the system.

Documented in chef-boneyard/chef-web-docs-2016#413

@@ -57,6 +57,10 @@ def initialize(name, service_commands=true)
:desc => "Show the configuration that would be generated by reconfigure.",
:arity => 1
},
"show-versions" => {
:desc => "Show the components and their versons comprising Chef Server.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: versons -> versions

@sean-horn
Copy link
Author

Thanks for the look, @stevendanna . I'll be back in here to cleanup soon.

@sean-horn sean-horn changed the title Add c-s-c show-versions subcommand Add c-s-c show-versions subcommand for master Dec 12, 2014
@sean-horn
Copy link
Author

@stevendanna Alright, this should be all fixed up now. It focuses on the current product rather than gathering all version manifest data on the system.

@sean-horn
Copy link
Author

PR for Manage' omnibus-ctl here #21

@smith
Copy link
Contributor

smith commented Apr 24, 2015

Could you clarify what the difference between this and #21 is? They look like they do the same thing.

@srenatus
Copy link
Contributor

srenatus commented Mar 9, 2017

@sean-horn Can I interest you in some archaeology? 😉 This change is still good, just needs a refreshment -- if you could rebase and sign-off (git commit --amend --no-edit -s) that commit, we could get this merged.

def show_versions(*args)
f = File.open("#{base_path}/version-manifest.txt")

while line = f.gets do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A filter of results using a search term of any remaining args would be nice. Would also need to change arity -> 2.

@@ -57,6 +57,10 @@ def initialize(name, service_commands=true)
:desc => "Show the configuration that would be generated by reconfigure.",
:arity => 1
},
"show-versions" => {
:desc => "Show the components and their versions comprising Chef Server.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project is used by more than just chef server so we'd need to make this statement more generic.

@tas50 tas50 closed this Oct 15, 2021
@tas50
Copy link
Contributor

tas50 commented Oct 15, 2021

Closing this out since we never heard back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants