-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add c-s-c show-versions subcommand for master #19
Conversation
@@ -57,6 +57,10 @@ def initialize(name, service_commands=true) | |||
:desc => "Show the configuration that would be generated by reconfigure.", | |||
:arity => 1 | |||
}, | |||
"show-versions" => { | |||
:desc => "Show the components and their versons comprising Chef Server.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: versons -> versions
Thanks for the look, @stevendanna . I'll be back in here to cleanup soon. |
546cad6
to
8a16fb7
Compare
8a16fb7
to
135898e
Compare
@stevendanna Alright, this should be all fixed up now. It focuses on the current product rather than gathering all version manifest data on the system. |
PR for Manage' omnibus-ctl here #21 |
Could you clarify what the difference between this and #21 is? They look like they do the same thing. |
@sean-horn Can I interest you in some archaeology? 😉 This change is still good, just needs a refreshment -- if you could rebase and sign-off ( |
def show_versions(*args) | ||
f = File.open("#{base_path}/version-manifest.txt") | ||
|
||
while line = f.gets do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A filter of results using a search term of any remaining args would be nice. Would also need to change arity -> 2.
@@ -57,6 +57,10 @@ def initialize(name, service_commands=true) | |||
:desc => "Show the configuration that would be generated by reconfigure.", | |||
:arity => 1 | |||
}, | |||
"show-versions" => { | |||
:desc => "Show the components and their versions comprising Chef Server.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project is used by more than just chef server so we'd need to make this statement more generic.
Closing this out since we never heard back. |
We should have a way to output the versions of components present on the system.
Documented in chef-boneyard/chef-web-docs-2016#413