Remove .git dir from embedded/apps #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The presence of a .git directory causes git to treat these directories as submodules, which causes the content to *not* get cached by the omnibus git cache, which in turn causes cached builds to have empty directories where the code was supposed to be. There is some benefit to keeping the .git directories around, but not enough to justify a more involved fix/workaround. So, blow the .git directories away during the build.
|
Didn't we fix this in chef/omnibus#121? |
|
@sethvargo I don't see how that could fix it at all. This is a fundamental problem with git, it pretty much refuses to commit any files in a subdirectory that contains a |
|
@sethvargo also, we never got an exception from omnibus-ruby, the whole build seems to work, but when it restores a build from the git cache, any subdir that git thinks is a git repo is empty. |
|
👍 |
lebauce
pushed a commit
to lebauce/omnibus-software
that referenced
this pull request
Dec 14, 2022
Add libffi as dependency of datadog-pip on arm platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence of a .git directory causes git to treat these directories
as submodules, which causes the content to not get cached by the
omnibus git cache, which in turn causes cached builds to have empty
directories where the code was supposed to be. There is some benefit to
keeping the .git directories around, but not enough to justify a more
involved fix/workaround. So, blow the .git directories away during the
build.
NOTE: I haven't built this yet, will be kicking off a build shortly.
/cc @opscode/client-eng @opscode/release-engineers