Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectively load softwares and projects #264

Merged
merged 14 commits into from
Jul 24, 2014

Conversation

sethvargo
Copy link
Contributor

Fixes #203

Preliminary benchmarks:

# Current
$ bundle exec omnibus build hamlet -l debug
0.97s user 0.43s system 69% cpu 2.008 total

# With patch
$ bundle exec omnibus build hamlet -l debug
0.90s user 0.33s system 73% cpu 1.684 total

It seems we are consistently shaving ~0.5s. However, when there are a lot of software and project definitions (omnibus-chef):

# Current
$ bundle exec omnibus list
3.21s user 0.75s system 88% cpu 4.455 total

# With patch
$ bundle exec omnibus list
0.84s user 0.31s system 75% cpu 1.537 total

In this instance, we can see a very significant gain in speed.

/cc @lamont-granquist @danielsdeleo @opscode/release-engineers

@schisamo
Copy link
Contributor

👍 nice to see so much red!

@sethvargo sethvargo merged commit 263343a into master Jul 24, 2014
@sethvargo sethvargo deleted the sethvargo/selective_load_software branch July 24, 2014 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only load required software definitions
2 participants