Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include secrets found in secrets.json in runtime omnibus config #1832

Merged
merged 1 commit into from Dec 18, 2019

Conversation

@robbkidd
Copy link
Member

robbkidd commented Dec 18, 2019

Description

When the secrets.json already exists, the config items weren't getting added to the node. Let's fix that.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.
Copy link
Member

joshbrand left a comment

LGTM!

When the secrets.json already exists, the config items weren't getting
added to the node. Let's fix that.

Signed-off-by: Robb Kidd <rkidd@chef.io>
@robbkidd robbkidd force-pushed the robb/actually-consume-secrets-json branch from 847b566 to 5683b8a Dec 18, 2019
@robbkidd robbkidd merged commit 4133315 into master Dec 18, 2019
3 checks passed
3 checks passed
DCO This commit has a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the robb/actually-consume-secrets-json branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.