Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git dependency #2429

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

dheerajd-msys
Copy link
Contributor

Signed-off-by: Dheeraj Singh Dubey dhsingh@progress.com

Description

-- Remove git dependency

Issues Resolved

Fixes : #1959

Check List

@dheerajd-msys dheerajd-msys requested review from a team as code owners December 9, 2021 11:57
@netlify
Copy link

netlify bot commented Dec 9, 2021

👷 Deploy Preview for chef-supermarket processing.

🔨 Explore the source changes: e9c8e3f

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/6204ff4aa46fb800072a3510

@dheerajd-msys
Copy link
Contributor Author

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Simplecov Report

Covered Threshold
97.24% 90%

@dheerajd-msys dheerajd-msys self-assigned this Dec 9, 2021
@tas50
Copy link
Contributor

tas50 commented Dec 9, 2021

Have we confirmed that nothing in Fieri is using git for repo checkouts?

@dheerajd-msys
Copy link
Contributor Author

Need to check that, will update here

@saghoshprogress saghoshprogress force-pushed the dheeraj/1959-remove-git-dependency branch from 2702dc8 to 8697cfe Compare January 3, 2022 08:34
@saghoshprogress saghoshprogress changed the title remove git dependency WIP: remove git dependency Jan 3, 2022
@dheerajd-msys
Copy link
Contributor Author

Manual testing is completed with following commands:

1. knife supermarket share <cookbook-name> -m https://<supermarket server IP> -o ~/chef-repo/cookbooks/ -V

2. knife supermarket download <cookbook_name> -m https://<supermarket IP>

3. knife supermarket download <cookbook_name> -m https://<supermarket IP>

4. knife supermarket unshare <cookbook_name> -m https://<supermarket IP>

5. knife cookbook upload

Signed-off-by: Dheeraj Singh Dubey <dhsingh@progress.com>
@dheerajd-msys dheerajd-msys force-pushed the dheeraj/1959-remove-git-dependency branch from 8697cfe to e9c8e3f Compare February 10, 2022 12:04
@tas50
Copy link
Contributor

tas50 commented Feb 10, 2022

Please ensure that all the cookbook quality metrics code works without git as well.

@dheerajd-msys
Copy link
Contributor Author

Yes @tas50 they are working as expected, Please check and confirm.

Screenshot 2022-02-14 at 3 13 55 PM

@dheerajd-msys dheerajd-msys changed the title WIP: remove git dependency Remove git dependency Feb 14, 2022
@sanga1794
Copy link
Contributor

Looks good to me.

@saghoshprogress saghoshprogress merged commit f8aa4cf into main Mar 3, 2022
@saghoshprogress saghoshprogress deleted the dheeraj/1959-remove-git-dependency branch March 3, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

See if we actually need the git software definition
5 participants