-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Chef/Security and InSpec/Deprecation cops #2575
Conversation
👷 Deploy Preview for chef-supermarket processing. 🔨 Explore the source changes: 3334056 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/62387d06530b5200082f48e9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
6b19af4
to
6352eb1
Compare
We need to fix the unit tests. |
We need to resolve the merge conflicts. |
6352eb1
to
801f8de
Compare
@RoyShravani conflicts resolved |
e00709a
to
3f75159
Compare
Fieri unit test are failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM syntax wise
Fieri test failures need to be checked @tas50 |
a0e4dc1
to
90070c5
Compare
Adhoc buildkite :- https://buildkite.com/chef/chef-supermarket-main-omnibus-adhoc/builds/424 Updated
|
We want to scan for these as well Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: pratixha <pratiksha.prajapati@msystechnologies.com>
90070c5
to
3334056
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
We want to scan for these as well
Signed-off-by: Tim Smith tsmith@chef.io