Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Chef/Security and InSpec/Deprecation cops #2575

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Feb 4, 2022

We want to scan for these as well

Signed-off-by: Tim Smith tsmith@chef.io

@tas50 tas50 requested review from a team as code owners February 4, 2022 17:40
@netlify
Copy link

netlify bot commented Feb 4, 2022

👷 Deploy Preview for chef-supermarket processing.

🔨 Explore the source changes: 3334056

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/62387d06530b5200082f48e9

Copy link
Contributor

@antima-gupta antima-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test is failing.

Copy link
Contributor

@RajeshPaul38 RajeshPaul38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@RoyShravani
Copy link
Contributor

We need to fix the unit tests.

@RoyShravani
Copy link
Contributor

We need to resolve the merge conflicts.

@tas50
Copy link
Contributor Author

tas50 commented Feb 17, 2022

@RoyShravani conflicts resolved

@tas50 tas50 force-pushed the cookstyle_copps branch 3 times, most recently from e00709a to 3f75159 Compare February 28, 2022 17:55
@ayushbhatt29
Copy link

Fieri unit test are failing.

Copy link
Contributor

@RajeshPaul38 RajeshPaul38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM syntax wise

@RajeshPaul38
Copy link
Contributor

Fieri test failures need to be checked @tas50

@pratixha
Copy link
Contributor

pratixha commented Mar 21, 2022

Adhoc buildkite :- https://buildkite.com/chef/chef-supermarket-main-omnibus-adhoc/builds/424

Updated

  • cookstyle from 7.31.1 to 7.32.1
  • chefstyle from 2.2.1 to 2.2.2
  • rubocop from 1.25.0 to 1.25.1
    Cookstyle cops - Chef/security was not included in cookstyle 7.31, it was causing spec failures

tas50 and others added 2 commits March 21, 2022 18:51
We want to scan for these as well

Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: pratixha <pratiksha.prajapati@msystechnologies.com>
Copy link
Contributor

@dheerajd-msys dheerajd-msys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@saghoshprogress saghoshprogress merged commit f1d7cdc into main Mar 22, 2022
@saghoshprogress saghoshprogress deleted the cookstyle_copps branch March 22, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants