Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two new i18n lint rules #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adding two new i18n lint rules #1

wants to merge 5 commits into from

Conversation

ehom
Copy link

@ehom ehom commented Apr 4, 2016

I'm interested in contributing to eslint-plugin-i18n. (I have more rules.)

Let me know if these look okay.

If so, don't merge yet since I'll have update the README.md file and the .md file for each new rule (and probably unit tests).

Thanks !!!

@codecov-io
Copy link

Current coverage is 100.00%

Merging #1 into master will not affect coverage as of 1f5c792

@@            master      #1   diff @@
======================================
  Files            1       2     +1
  Stmts            6      12     +6
  Branches         1       2     +1
  Methods          0       0       
======================================
+ Hit              6      12     +6
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 1f5c792

Powered by Codecov. Updated on successful CI builds.

@chejen
Copy link
Owner

chejen commented Apr 5, 2016

Thanks for the PR, these look nice. I'll merge these when you complete updates.

@ehom
Copy link
Author

ehom commented Apr 6, 2016

don't merge yet. one more test to submit.

@ntwb
Copy link

ntwb commented Jun 28, 2017

It would be great to see this pull request and package updated 😄

@ntwb
Copy link

ntwb commented Mar 13, 2018

@ehom Any chance you could update this PR please? It would be great to see these rules added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants