Typescript migration #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 89.07% // Head: 85.10% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 89.07% 85.10% -3.98%
==========================================
Files 44 37 -7
Lines 412 329 -83
Branches 83 84 +1
==========================================
- Hits 367 280 -87
- Misses 45 49 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
targos
reviewed
Jan 3, 2023
targos
reviewed
Jan 3, 2023
targos
reviewed
Jan 3, 2023
targos
reviewed
Jan 3, 2023
targos
reviewed
Jan 3, 2023
Comment on lines
+96
to
+97
| if (typeof e === 'string') { | ||
| result.error = e; |
There was a problem hiding this comment.
this is weird. we should never throw strings
There was a problem hiding this comment.
in our case yes.
i made this to make the general case that's all
There was a problem hiding this comment.
please keep it simple. we have rules that prevent throwing strings.
targos
reviewed
Jan 3, 2023
targos
reviewed
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.