feat: include parsed value in details for invalid text fields #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a value doesn't match the expected regex, it still has a clear value with start and end indexes. BREAKING CHANGE: The result's `details` may now include a non-null `value` even when it's invalid. The `start` and `end` fields will refer to it instead of the entire range when that happens. The `fields` object is unchanged and still contains `null` for invalid fields. Closes: #50
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 88.94% 89.46% +0.51%
==========================================
Files 44 44
Lines 380 389 +9
Branches 97 99 +2
==========================================
+ Hits 338 348 +10
+ Misses 42 41 -1 ☔ View full report in Codecov by Sentry. |
stropitek
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a value doesn't match the expected regex, it still has a clear value with start and end indexes.
BREAKING CHANGE: The result's
detailsmay now include a non-nullvalueeven when it's invalid.The
startandendfields will refer to it instead of the entire range when that happens.The
fieldsobject is unchanged and still containsnullfor invalid fields.Closes: #50