Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse french driving licences #55

Conversation

tpoisseau
Copy link
Contributor

  • /!\ target es2021 (instead es2020) to be able to use Intl.ListFormat
  • add documentCodeAlphaNumTemplate
  • add tests and fix errors.test.ts
  • without proper resources, I'm not sure about the real existence of A1, A2 or B1, but I let the parser flexible

Closes: #54

* /!\ target es2021 (instead es2020) to be able to use Intl.ListFormat
* add documentCodeAlphaNumTemplate
* add tests and fix errors.test.ts
* without proper resources,
  I'm not sure about the real existence
  of A1, A2 or B1,
  but I let the parser flexible

Closes: #54
@tpoisseau tpoisseau requested a review from targos April 11, 2024 13:10
@tpoisseau tpoisseau linked an issue Apr 11, 2024 that may be closed by this pull request
@tpoisseau
Copy link
Contributor Author

Shall I mark this PR as breaking change with new target ?

@targos
Copy link
Member

targos commented Apr 11, 2024

Tests pass on Node.js 18, so no.

@targos targos merged commit f7d7205 into main Apr 15, 2024
7 checks passed
@targos targos deleted the 54-support-1-row-mrz-like-french-driving-licences-credit-card-format branch April 15, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support 1 row MRZ like french driving licences (credit card format)
2 participants