Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add read function to use fileList only #59

Merged
merged 12 commits into from
Aug 22, 2022
Merged

feat!: add read function to use fileList only #59

merged 12 commits into from
Aug 22, 2022

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Jul 12, 2022

close: #60

@lpatiny
Copy link
Member

lpatiny commented Jul 12, 2022

Please check the tests as well

@jobo322
Copy link
Member Author

jobo322 commented Jul 15, 2022

Please check the tests as well

The test cases are waiting for the new versions of jeol-data-test and jcamp-data-test

@targos
Copy link
Member

targos commented Aug 15, 2022

@jobo322 I just merged some changes that I did on the main branch.

@lpatiny
Copy link
Member

lpatiny commented Aug 17, 2022

@jobo322 could you check that the tests are passing ?

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #59 (6cb76a3) into main (722ab32) will increase coverage by 0.04%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   92.29%   92.33%   +0.04%     
==========================================
  Files          12       13       +1     
  Lines         480      496      +16     
  Branches      176      183       +7     
==========================================
+ Hits          443      458      +15     
- Misses         35       36       +1     
  Partials        2        2              
Impacted Files Coverage Δ
src/fromJEOL.js 96.66% <ø> (ø)
src/utils/getDigitalFilterParameters.js 76.92% <ø> (ø)
src/read.js 94.11% <94.11%> (ø)
src/fromBruker.js 84.00% <100.00%> (-0.62%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lpatiny lpatiny merged commit 4cd204d into main Aug 22, 2022
@lpatiny lpatiny deleted the globalReader branch August 22, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from filelist-from to filelist-utils
3 participants